test: cover OTel replay and user callback contexts - #758
Open
zhongkechen wants to merge 20 commits into
Open
zhongkechen wants to merge 20 commits into
zhongkechen wants to merge 20 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
added 2 commits
October 3, 2026 02:58
This comment has been minimized.
This comment has been minimized.
added 2 commits
October 3, 2026 03:09
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Codex AI reviewNo actionable findings. Residual risk is limited to runtime behavior across the multi-version OTel/conformance matrix, which was not executed per review constraints. Reviewed commit |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Python handlers and SAM mappings for OTel cases 21–24: completed-step replay, active context in user functions and callbacks, and invocation retry status. User spans use ordinary implicit parenting. The handlers exercise public APIs through initial execution, wait/resume, failure, overlapping parallel/map branches, polling, callback submitters, retry helpers and virtual contexts.
Shared requirements: aws/aws-durable-execution-conformance-tests#131, pinned consistently to
6182cee00ed33ce01e0579066fb31096f988817f. Case 24 accepts canonical RETRYING followed by SUCCEEDED, optionally with a valid PENDING invocation between them; unexpected statuses/phases remain failures. This PR includes focused runtime prerequisites #756 and #752; merge those and the shared requirements first. Python #737 is excluded.The context correction isolates failed plugin setup and preserves token ownership, caller restoration and the original no-plugin path. Handler scopes require explicit concrete-class opt-in, leaving legacy helpers/properties/dynamic attributes untouched. Both OTel views preserve same-trace parents and baggage and bind their existing durable span when the worker parent is absent or unrelated. Provider API 1, dependency floors, registration lifetime and checkpoint/replay formats remain unchanged. Older supported cores retain their existing behavior.
Validation:
The earlier local tester duplicate wait-continuation behavior reproduces on unchanged main; deployed coverage and the original failure evidence are retained. Current-head cloud results and actual AI review generation/posting are verified separately.