Skip to content

test: cover OTel replay and user callback contexts - #758

Open
zhongkechen wants to merge 20 commits into
mainfrom
test/otel-conformance-feasibility
Open

zhongkechen wants to merge 20 commits into
mainfrom
test/otel-conformance-feasibility

Conversation

@zhongkechen

@zhongkechen zhongkechen commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Add Python handlers and SAM mappings for OTel cases 21–24: completed-step replay, active context in user functions and callbacks, and invocation retry status. User spans use ordinary implicit parenting. The handlers exercise public APIs through initial execution, wait/resume, failure, overlapping parallel/map branches, polling, callback submitters, retry helpers and virtual contexts.

Shared requirements: aws/aws-durable-execution-conformance-tests#131, pinned consistently to 6182cee00ed33ce01e0579066fb31096f988817f. Case 24 accepts canonical RETRYING followed by SUCCEEDED, optionally with a valid PENDING invocation between them; unexpected statuses/phases remain failures. This PR includes focused runtime prerequisites #756 and #752; merge those and the shared requirements first. Python #737 is excluded.

The context correction isolates failed plugin setup and preserves token ownership, caller restoration and the original no-plugin path. Handler scopes require explicit concrete-class opt-in, leaving legacy helpers/properties/dynamic attributes untouched. Both OTel views preserve same-trace parents and baggage and bind their existing durable span when the worker parent is absent or unrelated. Provider API 1, dependency floors, registration lifetime and checkpoint/replay formats remain unchanged. Older supported cores retain their existing behavior.

Validation:

  • All 83 core-package files match fix: propagate context into handler workers #756's tested tree: 1,778 core tests. The combined current-core OTel suite passes 404 tests; actual installed minimum core 2.0.0 passes 356 applicable tests. Repository type checks pass.
  • OTel conformance package 65, normal conformance package 11, and workflow wiring 3 tests pass. Case 22 uses the real local runner and barriers to force sibling overlap, without repairing tracing context in user functions.
  • The extended real SDK scope matrix covers span-binding plugins in both orders, same/unrelated/absent context, resumed success/failure, exact parents and cleanup. Four real installed core/plugin pairs pass 24 compatibility cases; current-core capability checks remain active and the legacy boundary is explicit.
  • Concurrent fixture hook output is serialized into complete JSON lines, backed by a regression that fails before the fix. Only the read-only ADOT layer lookup gets bounded standard retries for observed throttling. Requirements, wait timings, test timeouts, assertions, IAM and workflow trust are unchanged.
  • PR CI runs all 24 OTel cases in both views through ADOT/X-Ray and S3 against the exact SDK head and pinned requirements, with the failed-plus-uncovered gate enabled.

The earlier local tester duplicate wait-continuation behavior reproduces on unchanged main; deployed coverage and the original failure evidence are retained. Current-head cloud results and actual AI review generation/posting are verified separately.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 00:14 — with GitHub Actions Active
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 00:19 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen zhongkechen changed the title test(otel): cover replay and callback contexts test: add OTel conformance handlers 21–24 Oct 3, 2026
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 00:57 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen zhongkechen changed the title test: add OTel conformance handlers 21–24 test: add otel context and replay conformance Oct 3, 2026
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 02:08 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen zhongkechen changed the title test: add otel context and replay conformance test: cover OTel replay and user callback contexts Oct 3, 2026
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 02:26 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen changed the base branch from fix/otel-handler-context-428 to main October 3, 2026 02:37
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 02:38 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 03:02 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 03:14 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 05:20 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 3, 2026 05:26 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 4, 2026 01:39 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 4, 2026 02:13 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 6, 2026 02:37 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 6, 2026 04:11 — with GitHub Actions Active
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings. Residual risk is limited to runtime behavior across the multi-version OTel/conformance matrix, which was not executed per review constraints.

Reviewed commit 9055bdaaa93e8e0a9cdc8b387b76846db98c7b45. Workflow run

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — 9055bdaa Deployed Oct 6, 2026 by zhongkechen via ai-pr-review / Codex review / Generate Codex review #1296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant